Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: checkstyle rule for Java file headers: additional fixes #1042

Merged

Conversation

algattik
Copy link
Contributor

@algattik algattik commented Apr 1, 2022

What this PR changes/adds

This PR modifies some Java source files to enable the checkstyle header check rule in #997.

Why it does that

Reduce the developer overhead of fixing checkstyle header issues after merging #997.

Further notes

  • CyclicDependencyException.java: removed Jetty notice since the class is a generic implementation of EdcException
  • TopologicalSort.java: moved Jetty notice down so that standard header goes first
  • DataRequestMessageSender.java: deleted empty file
  • JsonFileGenerator.java: moved out of default package. This will also allow to create a package name rule later

Also fixed an unrelated merge remnant marker in a README file.

Linked Issue(s)

Relates to #991

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #1042 (9d0328d) into main (8da8f4c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1042   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity     2862     2862           
=========================================
  Files           671      671           
  Lines         14733    14733           
  Branches       1013     1013           
=========================================
  Hits           9514     9514           
  Misses         4755     4755           
  Partials        464      464           
Impacted Files Coverage Δ
...connector/boot/util/CyclicDependencyException.java 100.00% <ø> (ø)
.../dataspaceconnector/boot/util/TopologicalSort.java 92.85% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da8f4c...9d0328d. Read the comment docs.

@algattik algattik force-pushed the feature/991-header-additional-fixes branch 3 times, most recently from 5f78fd5 to 6a55e54 Compare April 1, 2022 13:44

Verified

This commit was signed with the committer’s verified signature.
@algattik algattik force-pushed the feature/991-header-additional-fixes branch from 6a55e54 to 25a4cf8 Compare April 1, 2022 13:46
@algattik algattik marked this pull request as ready for review April 1, 2022 14:01
@algattik algattik requested a review from juliapampus April 1, 2022 14:01
@juliapampus juliapampus merged commit 0d28139 into eclipse-edc:main Apr 1, 2022
@algattik algattik deleted the feature/991-header-additional-fixes branch June 22, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants