Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set z-index of hovers to 1000 #15172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set z-index of hovers to 1000 #15172

wants to merge 1 commit into from

Conversation

sgraband
Copy link
Contributor

@sgraband sgraband commented Mar 12, 2025 •
edited
Loading

What it does

Value taken from #15154.

Part of #15118.

How to test

  1. Build this branch
  2. Open Theia
  3. Set the window.tabbar.enhancedPreview to visual or enhanced
  4. Check that this does not happen:
    image

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@sgraband
Set z-index of hovers to 1000
3a90d36 
Value taken from #15154.

Part of #15118.

Signed-off-by: Simon Graband <[email protected]>
@JonasHelming
Copy link
Contributor

@cdamus Do you want to review this?

@cdamus
Copy link
Contributor

cdamus commented Mar 14, 2025

@cdamus Do you want to review this?

Happy to.

cdamus
cdamus approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@cdamus cdamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! The problems I had did not recur. I assume that this is unrelated as it appears to be a transparency glitch. I mean, who would put the icons of toolbar buttons at a higher z-index than 1000, amirite?

CleanShot 2025-03-14 at 08 40 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdamus cdamus cdamus approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Status: Waiting on reviewers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgraband @JonasHelming @cdamus