Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type declaration fix for 7.17.11 #1927

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Type declaration fix for 7.17.11 #1927

merged 3 commits into from
Jun 29, 2023

Conversation

JoshMock
Copy link
Member

Fixes #1924 and bumps npm package version to 7.17.11-patch.1.

JoshMock added 3 commits June 29, 2023 12:52
These prevented the TypeScript type-checker from running prior to a
release, and skipping (or, ideally, fixing if time were on our side)
the tests would have revealed a problem in
#1924 prior to
7.17.11 being published.
@JoshMock
Copy link
Member Author

Also notable: skipping some unit tests that were failing will ensure that TypeScript type-checking is run during npm test, until we can fix those failing tests. Because they were failing and known to be failing, it was easy to ignore a failed test run that hadn't yet run a type check.

@JoshMock JoshMock merged commit 4a88f2d into 7.17 Jun 29, 2023
@JoshMock JoshMock deleted the 7.17.11-patch.1 branch June 29, 2023 18:36
JoshMock added a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant