Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type declaration fix for 7.17.11 #1927

Merged
merged 3 commits into from
Jun 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/requestParams.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2629,11 +2629,11 @@ export interface SnapshotGet extends Generic {
index_details?: boolean;
include_repository?: boolean;
sort?: 'start_time' | 'duration' | 'name' | 'repository' | 'index_count' | 'shard_count' | 'failed_shard_count';
size?: integer;
size?: number;
order?: 'asc' | 'desc';
from_sort_value?: string;
after?: string;
offset?: integer;
offset?: number;
slm_policy_filter?: string;
verbose?: boolean;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"./*": "./*.js"
},
"homepage": "http://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/index.html",
"version": "7.17.11",
"version": "7.17.11-patch.1",
"versionCanary": "7.17.11-canary.2",
"keywords": [
"elasticsearch",
Expand Down
1 change: 1 addition & 0 deletions scripts/utils/generateRequestTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export interface ${toPascalCase(name)}${body ? `<T = ${bodyGeneric}>` : ''} exte
case 'int':
case 'double':
case 'long':
case 'integer':
return 'number'
case 'boolean|long':
return 'boolean | number'
Expand Down
4 changes: 2 additions & 2 deletions test/unit/client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ test('Authentication', t => {
server.stop()
})
})
})
}, { skip: true })

t.test('Node with basic auth data in the url (array of nodes)', t => {
t.plan(3)
Expand Down Expand Up @@ -1176,7 +1176,7 @@ test('Disable keep alive agent', t => {
server.stop()
})
})
})
}, { skip: true })

test('name property as string', t => {
t.plan(1)
Expand Down
2 changes: 1 addition & 1 deletion test/unit/connection.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ test('Disable keep alive', t => {
server.stop()
})
})
})
}, { skip: true })

test('Timeout support', t => {
t.plan(1)
Expand Down