-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate docs from AsciiDoc to Markdown #2806
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
Our Buildkite CI is currently broken, this is not related to this change. And Read the Docs was failing because it was using an image from the guide: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work!
Since we're planning to keep Read the Docs for API docs, I'm curious about the move from docs/guide
to docs/reference
which is a bit confusing in that regard. (Since I don't think of those docs as reference docs.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file about? Will it need to be kept up-to-date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used to configure the preview site for this repo. You can read more about it in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs document the format, but don't answer my question about future maintenance. Will the list of subs
need to change in the future? It currently contains hundreds of entries, copy/pasted across all those projects, I'm assuming.
(I'm just trying to understand, I'm not going to block this or anything.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair questions! The docs team is on the hook for subs
maintenance -- we had similar substitutions in the old system (and i'm thinking/hoping you didn't hear much about those)
in general I'd say docset.yml
is something the docs team can/should keep an eye on 👍
docs/docset.yml
Outdated
cross_links: | ||
- apm-agent-php | ||
- elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do those cross-links mean? Why APM Agent PHP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do those cross-links mean?
cross_links
defines all the other repos we link to in the docs in this repo. This is necessary for cross-repo link checking.
Why APM Agent PHP?
Good catch. I pushed an update in 3ab670e.
@pquentin Our new information architecture has these under |
@marciw Sure. Why is this still a draft? |
Wasn't sure it was ready but let's try it |
preview https://docs-v3-preview.elastic.dev/elastic/elasticsearch-py/pull/2806/reference/ (the broken-looking nav entries at the bottom are a known issue that will go away when the docs are all built together) |
DO NOT MERGE until preview has been reviewed
Migrate docs from AsciiDoc to Markdown. The preview can be built after #2805 is merged.