Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate docs from AsciiDoc to Markdown #2806

Merged
merged 8 commits into from
Mar 3, 2025

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Feb 26, 2025

DO NOT MERGE until preview has been reviewed

Migrate docs from AsciiDoc to Markdown. The preview can be built after #2805 is merged.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis marked this pull request as draft February 26, 2025 02:26
@pquentin
Copy link
Member

Our Buildkite CI is currently broken, this is not related to this change. And Read the Docs was failing because it was using an image from the guide: ../guide/images/create-api-key.png. I fixed that in #2806 (fc0cc82).

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work!

Since we're planning to keep Read the Docs for API docs, I'm curious about the move from docs/guide to docs/reference which is a bit confusing in that regard. (Since I don't think of those docs as reference docs.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file about? Will it need to be kept up-to-date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is used to configure the preview site for this repo. You can read more about it in the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs document the format, but don't answer my question about future maintenance. Will the list of subs need to change in the future? It currently contains hundreds of entries, copy/pasted across all those projects, I'm assuming.

(I'm just trying to understand, I'm not going to block this or anything.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair questions! The docs team is on the hook for subs maintenance -- we had similar substitutions in the old system (and i'm thinking/hoping you didn't hear much about those)

in general I'd say docset.yml is something the docs team can/should keep an eye on 👍

docs/docset.yml Outdated
Comment on lines 2 to 4
cross_links:
- apm-agent-php
- elasticsearch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do those cross-links mean? Why APM Agent PHP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do those cross-links mean?

cross_links defines all the other repos we link to in the docs in this repo. This is necessary for cross-repo link checking.

Why APM Agent PHP?

Good catch. I pushed an update in 3ab670e.

@marciw
Copy link
Contributor

marciw commented Feb 26, 2025

Since we're planning to keep Read the Docs for API docs, I'm curious about the move from docs/guide to docs/reference which is a bit confusing in that regard. (Since I don't think of those docs as reference docs.)

@pquentin Our new information architecture has these under /reference for now. We can iterate on the structure but would like to be able to go ahead and make this move in the meantime. Does that work for you?

@pquentin
Copy link
Member

@marciw Sure. Why is this still a draft?

@marciw marciw marked this pull request as ready for review February 27, 2025 13:50
@marciw
Copy link
Contributor

marciw commented Feb 27, 2025

@marciw Sure. Why is this still a draft?

Wasn't sure it was ready but let's try it

@marciw
Copy link
Contributor

marciw commented Feb 27, 2025

@marciw Sure. Why is this still a draft?

@pquentin ah, sorry -- forgot we need to merge #2805 first. Both that one and this one are failing the Buildkite CI as you mentioned; any way to work around that?

@marciw
Copy link
Contributor

marciw commented Feb 28, 2025

preview https://docs-v3-preview.elastic.dev/elastic/elasticsearch-py/pull/2806/reference/

(the broken-looking nav entries at the bottom are a known issue that will go away when the docs are all built together)
Screenshot 2025-02-28 at 9 40 46 AM

@marciw
Copy link
Contributor

marciw commented Feb 28, 2025

@marciw Sure. Why is this still a draft?

@pquentin ah, sorry -- forgot we need to merge #2805 first. Both that one and this one are failing the Buildkite CI as you mentioned; any way to work around that?

looks like you can ignore this 🙂 in #2805 Miguel mentioned the tests will be fixed soon.

@marciw marciw self-requested a review February 28, 2025 19:03
@pquentin pquentin merged commit d219dd9 into elastic:main Mar 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants