-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Migrate docs from AsciiDoc to Markdown #2806
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e76bf7e
delete asciidoc files
colleenmcginnis 4601f82
add migrated files
colleenmcginnis fc0cc82
Fix Read the Docs build
pquentin 3ab670e
fix links
colleenmcginnis c3b4208
Merge branch 'main' into migrate-docs
marciw 349e54a
Merge branch 'main' into migrate-docs
marciw ad57e42
clean up cross-repo links
colleenmcginnis 4a09380
Merge branch 'main' into migrate-docs
pquentin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file about? Will it need to be kept up-to-date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used to configure the preview site for this repo. You can read more about it in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs document the format, but don't answer my question about future maintenance. Will the list of
subs
need to change in the future? It currently contains hundreds of entries, copy/pasted across all those projects, I'm assuming.(I'm just trying to understand, I'm not going to block this or anything.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair questions! The docs team is on the hook for
subs
maintenance -- we had similar substitutions in the old system (and i'm thinking/hoping you didn't hear much about those)in general I'd say
docset.yml
is something the docs team can/should keep an eye on 👍