-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating bucket references from O11y to Ingest path #454
Conversation
This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
|
Hmm, all staging steps are failing with:
|
I'm no golang dependency expert, but with several version bumps being dealt with in other open PRs, feels like this should wait until those are resolved. |
I've just added the label for all the existing branches, so the same mechanism can be enabled in each branch even if they reached EOL, so we don't have any references to the former bucket. |
Alright, guess I'll just use this messy PR with long list of commits rather than opening a fresh one. They're all going to get squashed anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with just a couple of minor nits
go/llvm-apple/Dockerfile.tmpl
Outdated
@@ -61,11 +59,11 @@ RUN mkdir -p /tmp/osxcross | |||
# https://raw.githubusercontent.com/crazy-max/docker-osxcross/main/patches/lcxx.patch | |||
COPY lcxx.patch /tmp/osxcross/lcxx.patch | |||
|
|||
COPY sdks/MacOSX10.11.sdk.tar.xz tarballs/${OSX_SDK}.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think 10.11
could be replaced with a similar arg ${SDK_VERSION}
? However, it's not defined in the ARG section above, but it's already defined in go/darwin/Dockerfile.tmpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch! It looks like through my copy/paste that I changed which SDK version was getting used here. Will fix.
Co-authored-by: Victor Martinez <[email protected]>
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
💚 Build Succeeded
History
|
Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit 206cfe2) # Conflicts: # Makefile.common # README.md # go/Makefile.common # go/darwin/Dockerfile.tmpl # go/llvm-apple/Dockerfile.tmpl # go/main/Dockerfile.tmpl
Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit 206cfe2)
Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit 206cfe2)
Co-authored-by: Victor Martinez <[email protected]> (cherry picked from commit 206cfe2)
…path (#466) Co-authored-by: Geoff Rowland <[email protected]>
@v1v I see you closed the 1.16 backport, 1.17-1.19 don't seem to have backport PRs, and 1.20/1.21 are failing. Which versions do we need to support on this repo? |
I saw I think old branches might be affected by #444 and those branches are already EOL. For Golang, we only support the latest minor and previous minor, so I initially wanted to replace the Google bucket reference in the old branches, but I think we have never needed to build an EOL branch. Because backporting and fixing EOL branches is of little value, I think we are good with the current backports. We can close |
BTW, sorry If I was too enthusiastic and unclear about the rationale 🙇 |
Thanks very much. I closed 1.20 & 1.21. Appreciate the help. 🙇 |
Updating bucket references from
obs-ci-cache
toingest-buildkite-ci
Closes: https://github.com/elastic/ingest-dev/issues/3751