Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating bucket references from O11y to Ingest path #454
Updating bucket references from O11y to Ingest path #454
Changes from 63 commits
9f9b34a
79c7889
1c27a1e
fafd1b9
98f7ed2
7e47a11
80e9948
6999d79
c9df1a1
c11e968
a262c52
2d455f5
ccb79e8
6d37227
45a1269
758adaf
dae9ff6
f3052bb
7261b25
6aa8836
e668270
fb60a38
0564024
2a3f6bb
a1f7632
fbac907
be3a3b5
40ae11f
63aee44
bd97250
06e326c
b2a8317
96426ca
0fb95b2
10aa6ec
359b6b2
93ad11b
b323f1c
c3d4f5a
39d622f
4555565
f89c3a4
1d5526e
e279391
082c4f7
c9d26b0
f7be9a3
0e07dc9
04a68f9
5a841fd
1f26f78
8074083
52afa62
eb05571
4901395
c444782
6ab14a7
9543fe8
0211f16
f7bed96
f216c7c
e2fd8e2
6b2b78d
d2c940f
46617a2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think
10.11
could be replaced with a similar arg${SDK_VERSION}
? However, it's not defined in the ARG section above, but it's already defined ingo/darwin/Dockerfile.tmpl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good catch! It looks like through my copy/paste that I changed which SDK version was getting used here. Will fix.