[One Discover] Display stacktrace in the logs overview tab #204521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbamparop
added
release_note:skip
|
/ci |
gbamparop
force-pushed
the
discover-logs-stacktrace
branch
from
e11d28d to
b41227d
Compare
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/oblt-deploy |
|
/ci |
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
|
tonyghiani
approved these changes
Jan 21, 2025
jennypavlova
approved these changes
Jan 21, 2025
jughosta
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
Would it be possible to display stacktrace in the grid too? The current cells are not able to show this information in a readable way.
Some options:
- improve cells rendering but I guess it's tricky as stacktrace data is split in multiple fields, right?
- make the row button actionable: show the stacktrace in a popover or open the Logs Overview tab on click.
TinaHeiligers
approved these changes
Jan 21, 2025
@jughosta These are good ideas, thanks for sharing!
Displaying more complex APM stacktraces requires data from several subfields, however,
We have previously discussed it with the team, I've updated #190670 to include an action for the stacktrace section in addition to the quality section |
gbamparop
added
backport:version
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12912247501 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
I really like this idea too, and I think we could do it even if the data is split across fields. We have access to the full record when rendering a cell value, so we could use those other fields when rendering |
1 task
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…04521) ## 📓 Summary Adds a new section to the overview tab in the log details flyout in Discover to display stacktrace information for logs and exceptions. In a follow-up, the stacktrace could be moved to a new tab in the log details flyout and actions can be added to the stacktrace (and quality) icons in the document table to open the relevant sections in the flyout. Closes elastic#190460 ### APM - Log stacktrace (library frames) <img width="1470" alt="image" src="https://github.com/user-attachments/assets/8991f882-d329-4bc5-aa37-424576bcee72" /> ### APM - Exception (with cause) <img width="1476" alt="image" src="https://github.com/user-attachments/assets/cfbf24a7-6f82-48f1-b275-5aac977411ac" /> ### APM - Exception (simple stacktrace) <img width="1474" alt="image" src="https://github.com/user-attachments/assets/fc0306c4-5fcd-4b74-bb0d-c1784a48d677" /> ### Apache Tomcat Integration (Catalina) - Stacktrace <img width="1472" alt="image" src="https://github.com/user-attachments/assets/281f1822-faea-4e2d-9515-c11a9ee12f50" /> ## 📝 Notes for reviewers - The `@kbn/apm-types` package was marked as platform / shared as it's being used by the [unified_doc_viewer](https://github.com/elastic/kibana/blob/main/src/plugins/unified_doc_viewer/kibana.jsonc) - The code used to render stacktraces in APM was moved into a new `@kbn/event-stacktrace` package as it is reused in the `unified_doc_viewer` - The code used to render metadata table in APM was moved into a new `@kbn/key-value-metadata-table` package ## 🧪 Testing instructions The deployed environments have sample logs that can be used (time range: Jan 1, 2025 - now). For a local setup, please follow the instructions below: 1. Ingest sample logs with stacktraces ([gist](https://gist.github.com/gbamparop/0da21ca7f65b24c4a9c071ce9e9b97b0)). Please note that these are test data and some fields that are not used by stacktraces might not be consistent 2. View relevant logs in Discover (Query: `service.name: "synth-node-0" OR apache_tomcat :*`, Time range: Jan 1, 2025 - now) --------- Co-authored-by: kibanamachine <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gbamparop
added a commit
to gbamparop/kibana
that referenced
this pull request
Jan 23, 2025
…04521) ## 📓 Summary Adds a new section to the overview tab in the log details flyout in Discover to display stacktrace information for logs and exceptions. In a follow-up, the stacktrace could be moved to a new tab in the log details flyout and actions can be added to the stacktrace (and quality) icons in the document table to open the relevant sections in the flyout. Closes elastic#190460 ### APM - Log stacktrace (library frames) <img width="1470" alt="image" src="https://github.com/user-attachments/assets/8991f882-d329-4bc5-aa37-424576bcee72" /> ### APM - Exception (with cause) <img width="1476" alt="image" src="https://github.com/user-attachments/assets/cfbf24a7-6f82-48f1-b275-5aac977411ac" /> ### APM - Exception (simple stacktrace) <img width="1474" alt="image" src="https://github.com/user-attachments/assets/fc0306c4-5fcd-4b74-bb0d-c1784a48d677" /> ### Apache Tomcat Integration (Catalina) - Stacktrace <img width="1472" alt="image" src="https://github.com/user-attachments/assets/281f1822-faea-4e2d-9515-c11a9ee12f50" /> ## 📝 Notes for reviewers - The `@kbn/apm-types` package was marked as platform / shared as it's being used by the [unified_doc_viewer](https://github.com/elastic/kibana/blob/main/src/plugins/unified_doc_viewer/kibana.jsonc) - The code used to render stacktraces in APM was moved into a new `@kbn/event-stacktrace` package as it is reused in the `unified_doc_viewer` - The code used to render metadata table in APM was moved into a new `@kbn/key-value-metadata-table` package ## 🧪 Testing instructions The deployed environments have sample logs that can be used (time range: Jan 1, 2025 - now). For a local setup, please follow the instructions below: 1. Ingest sample logs with stacktraces ([gist](https://gist.github.com/gbamparop/0da21ca7f65b24c4a9c071ce9e9b97b0)). Please note that these are test data and some fields that are not used by stacktraces might not be consistent 2. View relevant logs in Discover (Query: `service.name: "synth-node-0" OR apache_tomcat :*`, Time range: Jan 1, 2025 - now) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 368475e) # Conflicts: # .github/CODEOWNERS # x-pack/platform/packages/shared/kbn-event-stacktrace/src/components/stacktrace/cause_stacktrace.tsx # x-pack/platform/packages/shared/kbn-event-stacktrace/src/components/stacktrace/frame_heading.tsx # x-pack/platform/packages/shared/kbn-event-stacktrace/src/components/stacktrace/library_stacktrace.tsx # x-pack/platform/packages/shared/kbn-event-stacktrace/src/components/stacktrace/stackframe.tsx # x-pack/platform/packages/shared/kbn-event-stacktrace/src/components/stacktrace/variables.tsx # x-pack/platform/packages/shared/kbn-key-value-metadata-table/src/formatted_value.tsx # x-pack/solutions/observability/plugins/apm/tsconfig.json
@davismcphee created a placeholder issue #208168 |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
gbamparop
added a commit
that referenced
this pull request
Jan 28, 2025
…4521) (#208115) # Backport This will backport the following commits from `main` to `8.x`: - [[One Discover] Display stacktrace in the logs overview tab (#204521)](#204521) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-22T16:06:14Z","message":"[One Discover] Display stacktrace in the logs overview tab (#204521)\n\n## 📓 Summary\r\nAdds a new section to the overview tab in the log details flyout in\r\nDiscover to display stacktrace information for logs and exceptions.\r\n\r\nIn a follow-up, the stacktrace could be moved to a new tab in the log\r\ndetails flyout and actions can be added to the stacktrace (and quality)\r\nicons in the document table to open the relevant sections in the flyout.\r\n\r\nCloses https://github.com/elastic/kibana/issues/190460\r\n\r\n### APM - Log stacktrace (library frames)\r\n<img width=\"1470\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/8991f882-d329-4bc5-aa37-424576bcee72\"\r\n/>\r\n\r\n### APM - Exception (with cause)\r\n<img width=\"1476\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cfbf24a7-6f82-48f1-b275-5aac977411ac\"\r\n/>\r\n\r\n### APM - Exception (simple stacktrace)\r\n<img width=\"1474\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fc0306c4-5fcd-4b74-bb0d-c1784a48d677\"\r\n/>\r\n\r\n### Apache Tomcat Integration (Catalina) - Stacktrace\r\n<img width=\"1472\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/281f1822-faea-4e2d-9515-c11a9ee12f50\"\r\n/>\r\n\r\n## 📝 Notes for reviewers\r\n- The `@kbn/apm-types` package was marked as platform / shared as it's\r\nbeing used by the\r\n[unified_doc_viewer](https://github.com/elastic/kibana/blob/main/src/plugins/unified_doc_viewer/kibana.jsonc)\r\n- The code used to render stacktraces in APM was moved into a new\r\n`@kbn/event-stacktrace` package as it is reused in the\r\n`unified_doc_viewer`\r\n- The code used to render metadata table in APM was moved into a new\r\n`@kbn/key-value-metadata-table` package\r\n\r\n## 🧪 Testing instructions\r\nThe deployed environments have sample logs that can be used (time range:\r\nJan 1, 2025 - now). For a local setup, please follow the instructions\r\nbelow:\r\n\r\n1. Ingest sample logs with stacktraces\r\n([gist](https://gist.github.com/gbamparop/0da21ca7f65b24c4a9c071ce9e9b97b0)).\r\nPlease note that these are test data and some fields that are not used\r\nby stacktraces might not be consistent\r\n2. View relevant logs in Discover (Query: `service.name: \"synth-node-0\"\r\nOR apache_tomcat :*`, Time range: Jan 1, 2025 - now)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"368475e8e55845e17fd4621c1ae60ba1e983bb8f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.18.0"],"title":"[One Discover] Display stacktrace in the logs overview tab","number":204521,"url":"https://github.com/elastic/kibana/pull/204521","mergeCommit":{"message":"[One Discover] Display stacktrace in the logs overview tab (#204521)\n\n## 📓 Summary\r\nAdds a new section to the overview tab in the log details flyout in\r\nDiscover to display stacktrace information for logs and exceptions.\r\n\r\nIn a follow-up, the stacktrace could be moved to a new tab in the log\r\ndetails flyout and actions can be added to the stacktrace (and quality)\r\nicons in the document table to open the relevant sections in the flyout.\r\n\r\nCloses https://github.com/elastic/kibana/issues/190460\r\n\r\n### APM - Log stacktrace (library frames)\r\n<img width=\"1470\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/8991f882-d329-4bc5-aa37-424576bcee72\"\r\n/>\r\n\r\n### APM - Exception (with cause)\r\n<img width=\"1476\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cfbf24a7-6f82-48f1-b275-5aac977411ac\"\r\n/>\r\n\r\n### APM - Exception (simple stacktrace)\r\n<img width=\"1474\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fc0306c4-5fcd-4b74-bb0d-c1784a48d677\"\r\n/>\r\n\r\n### Apache Tomcat Integration (Catalina) - Stacktrace\r\n<img width=\"1472\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/281f1822-faea-4e2d-9515-c11a9ee12f50\"\r\n/>\r\n\r\n## 📝 Notes for reviewers\r\n- The `@kbn/apm-types` package was marked as platform / shared as it's\r\nbeing used by the\r\n[unified_doc_viewer](https://github.com/elastic/kibana/blob/main/src/plugins/unified_doc_viewer/kibana.jsonc)\r\n- The code used to render stacktraces in APM was moved into a new\r\n`@kbn/event-stacktrace` package as it is reused in the\r\n`unified_doc_viewer`\r\n- The code used to render metadata table in APM was moved into a new\r\n`@kbn/key-value-metadata-table` package\r\n\r\n## 🧪 Testing instructions\r\nThe deployed environments have sample logs that can be used (time range:\r\nJan 1, 2025 - now). For a local setup, please follow the instructions\r\nbelow:\r\n\r\n1. Ingest sample logs with stacktraces\r\n([gist](https://gist.github.com/gbamparop/0da21ca7f65b24c4a9c071ce9e9b97b0)).\r\nPlease note that these are test data and some fields that are not used\r\nby stacktraces might not be consistent\r\n2. View relevant logs in Discover (Query: `service.name: \"synth-node-0\"\r\nOR apache_tomcat :*`, Time range: Jan 1, 2025 - now)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"368475e8e55845e17fd4621c1ae60ba1e983bb8f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204521","number":204521,"mergeCommit":{"message":"[One Discover] Display stacktrace in the logs overview tab (#204521)\n\n## 📓 Summary\r\nAdds a new section to the overview tab in the log details flyout in\r\nDiscover to display stacktrace information for logs and exceptions.\r\n\r\nIn a follow-up, the stacktrace could be moved to a new tab in the log\r\ndetails flyout and actions can be added to the stacktrace (and quality)\r\nicons in the document table to open the relevant sections in the flyout.\r\n\r\nCloses https://github.com/elastic/kibana/issues/190460\r\n\r\n### APM - Log stacktrace (library frames)\r\n<img width=\"1470\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/8991f882-d329-4bc5-aa37-424576bcee72\"\r\n/>\r\n\r\n### APM - Exception (with cause)\r\n<img width=\"1476\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/cfbf24a7-6f82-48f1-b275-5aac977411ac\"\r\n/>\r\n\r\n### APM - Exception (simple stacktrace)\r\n<img width=\"1474\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fc0306c4-5fcd-4b74-bb0d-c1784a48d677\"\r\n/>\r\n\r\n### Apache Tomcat Integration (Catalina) - Stacktrace\r\n<img width=\"1472\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/281f1822-faea-4e2d-9515-c11a9ee12f50\"\r\n/>\r\n\r\n## 📝 Notes for reviewers\r\n- The `@kbn/apm-types` package was marked as platform / shared as it's\r\nbeing used by the\r\n[unified_doc_viewer](https://github.com/elastic/kibana/blob/main/src/plugins/unified_doc_viewer/kibana.jsonc)\r\n- The code used to render stacktraces in APM was moved into a new\r\n`@kbn/event-stacktrace` package as it is reused in the\r\n`unified_doc_viewer`\r\n- The code used to render metadata table in APM was moved into a new\r\n`@kbn/key-value-metadata-table` package\r\n\r\n## 🧪 Testing instructions\r\nThe deployed environments have sample logs that can be used (time range:\r\nJan 1, 2025 - now). For a local setup, please follow the instructions\r\nbelow:\r\n\r\n1. Ingest sample logs with stacktraces\r\n([gist](https://gist.github.com/gbamparop/0da21ca7f65b24c4a9c071ce9e9b97b0)).\r\nPlease note that these are test data and some fields that are not used\r\nby stacktraces might not be consistent\r\n2. View relevant logs in Discover (Query: `service.name: \"synth-node-0\"\r\nOR apache_tomcat :*`, Time range: Jan 1, 2025 - now)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"368475e8e55845e17fd4621c1ae60ba1e983bb8f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Adds a new section to the overview tab in the log details flyout in Discover to display stacktrace information for logs and exceptions.
In a follow-up, the stacktrace could be moved to a new tab in the log details flyout and actions can be added to the stacktrace (and quality) icons in the document table to open the relevant sections in the flyout.
Closes #190460
APM - Log stacktrace (library frames)
APM - Exception (with cause)
APM - Exception (simple stacktrace)
Apache Tomcat Integration (Catalina) - Stacktrace
📝 Notes for reviewers
@kbn/apm-typespackage was marked as platform / shared as it's being used by the unified_doc_viewer@kbn/event-stacktracepackage as it is reused in theunified_doc_viewer@kbn/key-value-metadata-tablepackage🧪 Testing instructions
The deployed environments have sample logs that can be used (time range: Jan 1, 2025 - now). For a local setup, please follow the instructions below:
service.name: "synth-node-0" OR apache_tomcat :*, Time range: Jan 1, 2025 - now)