Generate Windows toolchain config #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @wrowe |
- Generate different platforms into toolchains/configs/${OS_FAMILY}
- Bumps bazel-toolchains dependency to 3.1.2 for Windows changes
- Remove all toolchains so CI regenerates them
- Reorder pipeline jobs to be serial, eliminates race between Linux and
Windows toolchain generation jobs pushing to envoy-build-tools master
Co-authored-by: Sunjay Bhatia <[email protected]>
Co-authored-by: William A Rowe Jr <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: William A Rowe Jr <[email protected]>
This was referenced May 21, 2020
|
@lizan when you get a chance, we would appreciate a review of this PR |
|
Windows CI run should be fixed by bazelbuild/bazel-toolchains#877, will bump to a version with that once it is ready |
lizan
reviewed
May 21, 2020
Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
sunjayBhatia
commented
May 22, 2020
Ensures if docker CLI is installed with spaces in path, bash can run the binary Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
|
The build finished, github seems to not have picked up the hook to change the status of the build here but it did pass: https://dev.azure.com/cncf/envoy/_build/results?buildId=40354&view=logs&j=3140c08e-0ceb-500c-a7fc-1cac300b6d64 |
Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
|
Looks like this went green again but Github missed the success hook on the ubuntu container build job |
|
@lizan this should be ready to review again, we can merge master again if you want but there shouldn't be any conflicts. All the checks have passed |
lizan
approved these changes
May 26, 2020
|
can you merge master? |
…onfig Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]>
|
@lizan should be good to go with master merged |
htuch
pushed a commit
that referenced
this pull request
May 26, 2020
[skip ci] Generate Windows toolchain config (#64) - To allow Linux and Windows toolchain configs to coexist, generate different platforms into toolchains/configs/${OS_FAMILY} - Bumps bazel-toolchains dependency to 3.1.2 for Windows changes - Remove all toolchains so CI regenerates them - Reorder pipeline jobs to be serial, eliminates race between Linux and Windows toolchain generation jobs pushing to envoy-build-tools master Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolchains/configs/${OS_FAMILY}
Windows toolchain generation jobs pushing to envoy-build-tools master