-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows build: Enable RBE build in Windows CI #11107
Conversation
- image uri/tag point to our temporary testing image, needs to be updated to the image in the envoyproxy repo - urls of bazel-toolchains and envoy-build-tools point to our spike branches, need to be changed to real versions once they are upstreamed - builds envoy-static and runs tests Co-authored-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]>
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This PR will be turned into a reviewable PR once envoyproxy/envoy-build-tools#64 is merged |
Signed-off-by: Sunjay Bhatia <[email protected]>
- Also bump build image tag - Use same mechanism to find build image tag on Windows and Linux Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
This may cause format to fail for some PRs since the CI image is bumped to one with llvm 10 (and clang-format 10). If that is undesirable as part of this change, we can submit another to bump that dependency separately. |
Signed-off-by: Sunjay Bhatia <[email protected]>
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
just waiting on envoyproxy/envoy-build-tools#70 to help us generate an updated toolchain config |
- Brings in newly generated ubuntu, windows docker images for RBE Signed-off-by: William A Rowe Jr <[email protected]>
Unclear whether the released 3.2.0 bazel version will be compatible; the final post-3.1.2 tag which picked up the the windows path fixes was;
|
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Surface additional failing tests for visibility before we get Windows running in CI. Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
- yaml-cpp parser should be treating cr+lf as newline per spec Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Looks like the recent Specifically this change: bazel-contrib/rules_go#2488 |
Blocked on bazel-contrib/rules_go#2542 |
Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]>
can be removed once Bazel/RBE issue is addressed Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]> Signed-off-by: Sunjay Bhatia <[email protected]>
Blocked by PR #11719 |
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
No longer blocked on the rules_go PR, we have a patch in this PR for rules_go and an open issue here to track figuring out the true root cause: #11657 |
cc @nigriMSFT @davinci26 if you weren't aware of this one |
This reverts commit acfaa9a. Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
We have rolled up all regression fixes into a single distinct PR. #11719 needs to be applied before this one. |
Signed-off-by: Sunjay Bhatia <[email protected]> Co-authored-by: Sunjay Bhatia <[email protected]> Signed-off-by: William A Rowe Jr <[email protected]> Co-authored-by: William A Rowe Jr <[email protected]>
Fix network utility test Signed-off-by: Sunjay Bhatia <[email protected]>
Assuming no more test flakes, this PR should be ready for review @lizan |
https://dev.azure.com/cncf/envoy/_build/results?buildId=43158&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=168f295b-0553-5364-35f7-923225ecd8b3 represents a Windows build where all tests are compiled and the ones known to pass are run |
@lizan the TSAN failure seems to also be occurring on master, it should not be related to this change |
@sunjayBhatia merge master will help I think. Since #11760 is merged. |
@dio Sure, will do Can we get a review on this soon so we don't slip behind the newly merged PRs that might cause Windows breakages again? |
Signed-off-by: Sunjay Bhatia <[email protected]>
Commit Message:
Enable RBE build in Windows CI
Additional Description: N/A
Risk Level: Low, but we may observe differences in performance of Windows CI running remotely, we may need to adjust the worker pool accordingly
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Fixes #10619