Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove priting of opt status when checking previous run #10225

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oyvindeide
Copy link
Collaborator

This feature made the client go into the server storage, and we need to have separation between between the frontend and the backend.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

This feature made the client go into the server storage, and
we need to have separation between between the frontend and
the backend.
@oyvindeide oyvindeide mentioned this pull request Mar 6, 2025
9 tasks
Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #10225 will degrade performances by 10.49%

Comparing oyvindeide:remove_printing (e6bfe64) with main (d7bf0e9)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 5.8 ms 6.5 ms -10.49%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant