Add allow-empty overload field on Process.run #10736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
Process.run()
to fail by default if the command does not return any output.This causes failures in any test which uses getContractFunctionAbis, indicating thatgetContractFunctionAbis
has been failing silently due to a zero length array of abis:optimism/packages/contracts-bedrock/scripts/ForgeArtifacts.sol
Lines 188 to 192 in 921c3ce
This PR is intended to demonstrate this. A fix is also needed togetContractFunctionAbis
.Update: The changes in PR #10739 fix
getContractFunctionAbis
, so this change can now be applied without breaking existing functionality.