Fix Specification_Test #10739
Merged
Fix Specification_Test #10739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10739 +/- ##
============================================
- Coverage 54.65% 39.26% -15.39%
============================================
Files 37 27 -10
Lines 2944 1821 -1123
Branches 415 415
============================================
- Hits 1609 715 -894
+ Misses 1303 1106 -197
+ Partials 32 0 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
approved these changes
Jun 5, 2024
rdovgan
pushed a commit
to rdovgan/optimism
that referenced
this pull request
Jun 24, 2024
* Fix Specification_Test * fix the rest of the spec tests * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a silent failure in the Spec test and asserts that all user-defined specs are actually checked against ABI.
Updated the
SystemConfigspec test now that it's found to be underspecified