Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_feeHistory blob gas used ratio error #31245

Closed
sebaespindola opened this issue Feb 24, 2025 · 2 comments · Fixed by #31246
Closed

eth_feeHistory blob gas used ratio error #31245

sebaespindola opened this issue Feb 24, 2025 · 2 comments · Fixed by #31246
Labels

Comments

@sebaespindola
Copy link

System information

Geth version: 1.15.2
CL client & version: Teku
OS & Version: Linux

There seems to be a bug in the eth_feeHistory method. The blob gas used ratio is no longer a coefficient:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "oldestBlock": "0x76ac95",
    "baseFeePerGas": [
      "0x17a2450f4",
      "0x16be16dff",
      "0x168412aff",
      "0x16cd1cde6",
      "0x157794815"
    ],
    "gasUsedRatio": [
      0.34914364543796966,
      0.4601405237392908,
      0.5506862222222222,
      0.26595780555555554
    ],
    "baseFeePerBlobGas": [
      "0x26609f9",
      "0x27ea052",
      "0x27ea052",
      "0x2ce745d",
      "0x30924a1"
    ],
    "blobGasUsedRatio": [
      87381.33333333333,
      65536,
      131072,
      109226.66666666667
    ]
  }
}

The regression seems to have been created here

lightclient pushed a commit that referenced this issue Feb 26, 2025
This change divides BlobGasUsed by MaxBlobGasPerBlock instead of
MaxBlobsPerBlock. Dividing by MaxBlobsPerBlock
meant the blobGasUsedRatio was an incorrect large number. This bug was
introduced by a typo
[here](e6f3ce7#diff-3357b2399699d7cf954c543cbfb02ff442eb24491e55f5e813e3cc85829b3e8dR110)

Fixes #31245
rjl493456442 pushed a commit that referenced this issue Feb 27, 2025
Follow on to #31246. Adds a sanity check in the test to make sure the
ratio value never goes over 1. Would have avoided the issue in #31245.
buddh0 pushed a commit to buddh0/bsc that referenced this issue Feb 27, 2025
This change divides BlobGasUsed by MaxBlobGasPerBlock instead of
MaxBlobsPerBlock. Dividing by MaxBlobsPerBlock
meant the blobGasUsedRatio was an incorrect large number. This bug was
introduced by a typo
[here](ethereum/go-ethereum@e6f3ce7#diff-3357b2399699d7cf954c543cbfb02ff442eb24491e55f5e813e3cc85829b3e8dR110)

Fixes ethereum/go-ethereum#31245
buddh0 pushed a commit to buddh0/bsc that referenced this issue Feb 27, 2025
This change divides BlobGasUsed by MaxBlobGasPerBlock instead of
MaxBlobsPerBlock. Dividing by MaxBlobsPerBlock
meant the blobGasUsedRatio was an incorrect large number. This bug was
introduced by a typo
[here](ethereum/go-ethereum@e6f3ce7#diff-3357b2399699d7cf954c543cbfb02ff442eb24491e55f5e813e3cc85829b3e8dR110)

Fixes ethereum/go-ethereum#31245
@jamesstanleystewart
Copy link
Contributor

@fjl Would this regression fix warrant being included in a 1.15.4 release? Ideally we'd love to be able to release this fix before pectra hits sepolia so we don't have the known issue with serving feeHistory rpc requests.

@fjl
Copy link
Contributor

fjl commented Feb 27, 2025

Yes, 1.15.4 will be released soon!

Donk3ys pushed a commit to Libex-LLC/lbx-chain that referenced this issue Mar 4, 2025
This change divides BlobGasUsed by MaxBlobGasPerBlock instead of
MaxBlobsPerBlock. Dividing by MaxBlobsPerBlock
meant the blobGasUsedRatio was an incorrect large number. This bug was
introduced by a typo
[here](ethereum/go-ethereum@e6f3ce7#diff-3357b2399699d7cf954c543cbfb02ff442eb24491e55f5e813e3cc85829b3e8dR110)

Fixes ethereum/go-ethereum#31245
noslav pushed a commit to covalenthq/bsp-geth that referenced this issue Mar 11, 2025
This change divides BlobGasUsed by MaxBlobGasPerBlock instead of
MaxBlobsPerBlock. Dividing by MaxBlobsPerBlock
meant the blobGasUsedRatio was an incorrect large number. This bug was
introduced by a typo
[here](ethereum/go-ethereum@e6f3ce7#diff-3357b2399699d7cf954c543cbfb02ff442eb24491e55f5e813e3cc85829b3e8dR110)

Fixes ethereum/go-ethereum#31245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants