Error when running smoke tests #165
Comments
|
It looks like one underlying factor here is that the ci workflow didn't run on #161 due to the nim-test-runner/.github/workflows/ci.yml Lines 3 to 8 in 05911af This is a perfect example of how ignoring paths can decrease robustness. It's impossible to pin everything with alpine, so a docs-only change in this repo doesn't mean that everything else still works. If we're autodeploying on pushing to main, it's critical that exact state is fully tested beforehand. |
|
Agreed. Feel free to remove those ignore paths. |
|
Isn't the issue that we deploy even when we ignore paths? |
Well, yes, but one way to avoid that is to not merge PRs that fail CI.
I don't think it was, but I think (part of) the Dockerfile was rebuilt and that introduced an error. Do you have any idea on what causes the error? |
I have some suspicions. I'll try to look later today. |
|
I've tried to upgrade to the latest Alpine version but that didn't seem to help. |
|
Should be fixed by #170. |
Despite no change to the Dockerfile on our end, we were seeing an error:
tcc: error: libtcc1.a not found
This was due to Alpine splitting the tcc package [1] into:
- tcc
- tcc-dev
- tcc-doc
- tcc-libs
- tcc-libs-static
combined with the other underlying problems:
- The tcc package isn't pinned, because we can't reliably pin package
versions on Alpine [2]
- The tcc package in Alpine is in the testing repo, which makes breaking
changes more likely
- The CI workflow was skipped in a PR that changed only docs, but would
have failed if it ran
- The deployment workflow runs on main even if the CI workflow fails on
main
Install the new tcc-libs-static subpackage so that libtcc1.a is
available again. See the contents of the tcc packages [3][4][5][6][7].
This commit also bumps the tcc version, because the current state [8]
was deployed after the upstream bump [9].
Fixes: #165
Fixes: #166
[1] https://git.alpinelinux.org/aports/commit/?id=e2fff91d821a89e4ce5a205207181ed9fdb18c16
[2] https://gitlab.alpinelinux.org/alpine/abuild/-/issues/9996
[3] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc&arch=x86_64&repo=testing
[4] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2ddev&arch=x86_64&repo=testing
[5] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2ddoc&arch=x86_64&repo=testing
[6] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2dlibs&arch=x86_64&repo=testing
[7] https://pkgs.alpinelinux.org/contents?branch=edge&name=tcc%2dlibs%2dstatic&arch=x86_64&repo=testing
[8] bcb2010, 2023-10-06, ".github(pause-community-contributions): add custom token"
[9] https://git.alpinelinux.org/aports/commit/testing?id=d697e994f093e65208d05a83bf2a0a9750002d20
There is an error when running the smoke tests:
See https://github.com/exercism/nim-test-runner/actions/runs/8156023911/job/22292767646?pr=164 for the workflow run that failed.
See https://forum.exercism.org/t/nim-test-runner-bug-after-exercism-submit/10088/8 for the original mention.
The text was updated successfully, but these errors were encountered: