Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: install tcc-libs-static #170

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Mar 7, 2024

Despite no change to the Dockerfile on our end, we were seeing an error:

tcc: error: libtcc1.a not found

This was due to Alpine splitting the tcc package into:

  • tcc
  • tcc-dev
  • tcc-doc
  • tcc-libs
  • tcc-libs-static

combined with the other underlying problems:

  • The tcc package in Alpine is in the testing repo, which makes breaking changes more likely
  • The CI workflow was skipped in a PR that changed only docs, but would have failed if it ran
  • The deployment workflow runs on main even if the CI workflow fails on main
  • The tcc package isn't pinned, because we can't reliably pin package versions on Alpine:

# We can't reliably pin the package versions on Alpine, so we ignore the linter warning.
# See https://gitlab.alpinelinux.org/alpine/abuild/-/issues/9996
# hadolint ignore=DL3018
RUN apk add --no-cache \
gcc \
musl-dev

# hadolint ignore=DL3018
RUN apk add --no-cache \
musl-dev \
pcre \
&& apk add --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/edge/testing \
tcc \

Install the new tcc-libs-static subpackage so that libtcc1.a is available again. See the contents of the tcc packages:

This commit also bumps the tcc version, because the current state (bcb2010) was deployed after the upstream bump.

Fixes: #165
Fixes: #166

@ee7 ee7 changed the title Dockerfile: install tcc-dev Dockerfile: install tcc-libs-static Mar 7, 2024
@ee7 ee7 marked this pull request as ready for review March 7, 2024 21:13
@ee7 ee7 requested a review from a team as a code owner March 7, 2024 21:13
@ee7 ee7 requested a review from ynfle March 7, 2024 21:13
@ee7 ee7 merged commit eb12635 into exercism:main Mar 8, 2024
4 checks passed
@ee7 ee7 deleted the Dockerfile-tcc branch March 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pushing to main will break prod Error when running smoke tests
2 participants