feat: add example stubs #12679
Merged
feat: add example stubs #12679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only added evident type hints. I'll add those later on, either in this PR or the next - let me know what works best since I'll likely have little time for that in the next few days. |
adrianeboyd
reviewed
Jun 9, 2023
adrianeboyd
reviewed
Jul 6, 2023
| @@ -19,14 +20,19 @@ | |||
| FILE_TYPE = ".spacy" | |||
|
|
|||
|
|
|||
| class ReaderProtocol(Protocol): | |||
| def __call__(self, nlp: "Language") -> Iterable[Example]: | |||
There was a problem hiding this comment.
I thought Iterator[Example] was correct throughout here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a stubs file for
spacy.training.example. It also fixes a few typing-related issues.Types of change
This is an enhancement.
Checklist