Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example stubs (2) #12798

Merged
merged 7 commits into from
Jul 6, 2023

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Jul 6, 2023

Follow up of #12679 after premature merge due to unsynced CI checks...

Description

This PR adds a stubs file for spacy.training.example. It also fixes a few typing-related issues.

Types of change

enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg mentioned this pull request Jul 6, 2023
3 tasks
@svlandeg svlandeg added enhancement Feature requests and improvements types Issues related to typing or typing tools labels Jul 6, 2023
@svlandeg svlandeg changed the base branch from master to feature/type_fixes July 6, 2023 15:33
@svlandeg
Copy link
Member Author

svlandeg commented Jul 6, 2023

I'm merging this to an Explosion branch first so we can more easily build on it.

@svlandeg svlandeg merged commit 69fd65d into explosion:feature/type_fixes Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements types Issues related to typing or typing tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants