Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update br tags #12882

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Update br tags #12882

merged 2 commits into from
Aug 4, 2023

Conversation

adrianeboyd
Copy link
Contributor

@adrianeboyd adrianeboyd commented Aug 2, 2023

Description

I think the intention in displacy was <br/>, but maybe now <br> would be better (says the w3c markup validator anyway)?

Types of change

Bug fix?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added the feat / visualizers Feature: Built-in displaCy and other visualizers label Aug 2, 2023
@rmitsch
Copy link
Contributor

rmitsch commented Aug 3, 2023

Does this fix a bug? I just wouldn't want to assume the closing tag is an opening tag. <br> should be sufficient now AFAIK, yes (not an expert though).

@adrianeboyd
Copy link
Contributor Author

I think all browsers probably render <br>, </br>, and <br/> the same so it's not exactly a bug? It's been like this for ages. I'd noticed a few times in the past when inspecting the rendering but never worried about it beyond that. But I don't think that </br> has ever been an actual valid tag?

@rmitsch
Copy link
Contributor

rmitsch commented Aug 3, 2023

Ah right, it's just line break.

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the w3c markup validator suggests <br> I would yet change it into that, but I suspect that it won't make a practical difference either way.

@adrianeboyd adrianeboyd changed the title Fix displacy br tag Update br tags Aug 4, 2023
@svlandeg svlandeg merged commit 45af8a5 into explosion:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat / visualizers Feature: Built-in displaCy and other visualizers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants