Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update br tags #12882

Merged
merged 2 commits into from
Aug 4, 2023
+4 −4
Merged

Update br tags #12882

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
434c2a4
Fix displacy br tag
adrianeboyd Aug 2, 2023
d22d497
Prefer <br>, also update package CLI
adrianeboyd Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spacy/displacy/render.py
View file
Original file line number Diff line number Diff line change
@@ -567,7 +567,7 @@ def render_ents(
for i, fragment in enumerate(fragments):
markup += escape_html(fragment)
if len(fragments) > 1 and i != len(fragments) - 1:
markup += "</br>"
markup += "<br/>"
if self.ents is None or label.upper() in self.ents:
color = self.colors.get(label.upper(), self.default_color)
ent_settings = {
@@ -585,7 +585,7 @@ def render_ents(
for i, fragment in enumerate(fragments):
markup += escape_html(fragment)
if len(fragments) > 1 and i != len(fragments) - 1:
markup += "</br>"
markup += "<br/>"
markup = TPL_ENTS.format(content=markup, dir=self.direction)
if title:
markup = TPL_TITLE.format(title=title) + markup
2 changes: 1 addition & 1 deletion spacy/tests/test_displacy.py
View file
Original file line number Diff line number Diff line change
@@ -113,7 +113,7 @@ def test_issue5838():
doc = nlp(sample_text)
doc.ents = [Span(doc, 7, 8, label="test")]
html = displacy.render(doc, style="ent")
found = html.count("</br>")
found = html.count("<br/>")
assert found == 4