Better error message when GitHub token is missing #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to access GitHub during development, GitHub access token needs to be manually set in the configuration file. This is unavoidable, since developer's own token is needed. On the other hand, the error message about missing token was not very clear because it was just 401 Unauthenticated from GitHub. A special error message for the case of unset token is added. This tells developers clearly what is wrong in their setup and is not worse than 401 in a production setup.
oturpe
force-pushed
the
better-github-token-error
branch
from
f6f80a0 to
fa73098
Compare
|
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
|
Zlopez
approved these changes
Sep 20, 2021
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to access GitHub during development,
GitHub access token needs to be manually set
in the configuration file.
This is unavoidable, since developer's own token is needed.
On the other hand,
the error message about missing token was not very clear
because it was just 401 Unauthenticated from GitHub.
A special error message for the case of unset token is added.
This tells developers clearly what is wrong in their setup
and is not worse than 401 in a production setup.