Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy check fails with Alembic 1.7.3 #1183

Closed
oturpe opened this issue Sep 20, 2021 · 1 comment · Fixed by #1188
Closed

mypy check fails with Alembic 1.7.3 #1183

oturpe opened this issue Sep 20, 2021 · 1 comment · Fixed by #1188

Comments

@oturpe
Copy link
Contributor

oturpe commented Sep 20, 2021 •
edited
Loading

This issue was discovered by the ci run of #1182.
Mypy check fails with the following error:

anitya/db/migrations/env.py:21: error: Argument 1 to "fileConfig" has incompatible type "Optional[str]"; expected "Union[Union[str, bytes, PathLike[str], PathLike[bytes]], IO[str], RawConfigParser]"

Forcing Alembic version to be 1.7.1 in requirements.txt fixes the issue.
@Zlopez
Copy link
Contributor

Zlopez commented Sep 20, 2021

I thought I already fixed this one in #1178, but it seems like there is something new. I will look at it today.

Zlopez added a commit to Zlopez/anitya that referenced this issue Sep 20, 2021
@Zlopez
Fix mypy error
c90a9df 
logging.config.fileConfig doesn't allow Optional[str] anymore, so we
need to convert the value to str.

Fixes fedora-infra#1183

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez mentioned this issue Sep 20, 2021
Merged
Zlopez added a commit that referenced this issue Sep 20, 2021
@Zlopez
Fix mypy error
e8b5119 
logging.config.fileConfig doesn't allow Optional[str] anymore, so we
need to convert the value to str.

Fixes #1183

Signed-off-by: Michal Konečný <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mypy error Zlopez/anitya
2 participants
@oturpe @Zlopez