Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy error #1188

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Fix mypy error #1188

merged 1 commit into from
Sep 20, 2021

Conversation

Zlopez
Copy link
Contributor

@Zlopez Zlopez commented Sep 20, 2021

logging.config.fileConfig doesn't allow Optional[str] anymore, so we
need to convert the value to str explicitly.

Fixes #1183

Signed-off-by: Michal Konečný [email protected]

logging.config.fileConfig doesn't allow Optional[str] anymore, so we
need to convert the value to str.

Fixes fedora-infra#1183

Signed-off-by: Michal Konečný <[email protected]>
@Zlopez Zlopez requested a review from a team as a code owner September 20, 2021 12:04
@softwarefactory-project-zuul
Copy link

Build succeeded.

@Zlopez Zlopez merged commit e8b5119 into fedora-infra:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy check fails with Alembic 1.7.3
1 participant