Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy May 30, 2023 #4643

Merged
merged 131 commits into from
May 30, 2023
Merged

Deploy May 30, 2023 #4643

merged 131 commits into from
May 30, 2023

Conversation

canova
Copy link
Member

@canova canova commented May 30, 2023

petercpg and others added 30 commits April 18, 2023 14:55
julienw and others added 27 commits May 19, 2023 09:49
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Nazım Can Altınova <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Nazım Can Altınova <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Nazım Can Altınova <[email protected]>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…tracks to avoid visual noise on dense charts. (PR #4634)
…ransforms

Before the 'filter-samples' transform, we didn't need to get the
derived markers to be able to compute any thread related pre-thread
selectors. But with 'filter-samples' transform, we need to get the
derived markers to be able to compute the transform filtered thread
because this transform needs to find the markers that match the filter
and get the interval range out of them.

So because of this, I had to split the thread related selectors so we
can get the marker selectors in between them and have the marker
selectors in the second phase of thread selectors.

Previously the dependency graph was like this:

```
thread selectors
     |
     v
stack and sample
     +
marker selectors
     |
     v
composed selectors
```

Now it's like this:

```
basic thread selectors
       |
       v
marker selectors
       |
       v
rest of the thread selectors
       |
       v
stack and sample selectors
       |
       v
composed selectors
```

We can't put these thread selectors that require markers into the
`composed` selectors because stack and sample selectors require those
selectors earlier in the pipeline and I wanted to keep the thread
selectors still in their file to keep the pipeline in a single file.
@canova canova requested a review from a team as a code owner May 30, 2023 12:33
@canova canova removed the request for review from a team May 30, 2023 12:33
@canova canova merged commit 2c3e2af into production May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.