fix: check for case where client sends null for max_quantity #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #6344 +/- ##
============================================
Coverage 65.26% 65.26%
============================================
Files 287 287
Lines 14754 14754
============================================
Hits 9629 9629
Misses 5125 5125
Continue to review full report at Codecov.
|
app/api/schema/discount_codes.py
Outdated
| @@ -86,7 +86,7 @@ def validate_quantity(self, data, original_data): | |||
|
|
|||
| DiscountCodeSchemaEvent.quantity_validation_helper(data) | |||
|
|
|||
| if 'tickets_number' in data and 'max_quantity' in data: | |||
| if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None: | |||
There was a problem hiding this comment.
Suggested change
| if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None: | |
| if data.get('tickets_number') and data.get('max_quantity'): |
app/api/schema/discount_codes.py
Outdated
| @@ -149,7 +149,7 @@ def validate_quantity(self, data, original_data): | |||
|
|
|||
| DiscountCodeSchemaTicket.quantity_validation_helper(data) | |||
|
|
|||
| if 'tickets_number' in data and 'max_quantity' in data: | |||
| if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None: | |||
app/api/schema/discount_codes.py
Outdated
| @@ -149,7 +149,7 @@ def validate_quantity(self, data, original_data): | |||
|
|
|||
| DiscountCodeSchemaTicket.quantity_validation_helper(data) | |||
|
|
|||
| if 'tickets_number' in data and 'max_quantity' in data: | |||
| if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None: | |||
There was a problem hiding this comment.
Suggested change
| if 'tickets_number' in data and 'max_quantity' in data and data['max_quantity'] is not None: | |
| if data.get('tickets_number') and data.get('max_quantity'): |
iamareebjamal
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6343
There is a case where the client does supply the value for maximum discount codes, by specifying that it is null, this PR handles that case to prevent validation code from breaking.