Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map all Windows sysvol paths to their drive letter #119

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Jan 17, 2024

Required for fox-it/dissect.target#497.

Allows dissect.target to support acquire outputs for systems that have a non-default sysvol drive letter.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b076f2) 44.64% compared to head (4d0721c) 44.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   44.64%   44.78%   +0.13%     
==========================================
  Files          23       23              
  Lines        2905     2912       +7     
==========================================
+ Hits         1297     1304       +7     
  Misses       1608     1608              
Flag Coverage Δ
unittests 44.78% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco merged commit 0a35a8e into main Jan 31, 2024
30 checks passed
@pyrco pyrco deleted the sysvol-mapping branch January 31, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants