Support Windows installations on alternative drive letters #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
=======================================
Coverage 73.79% 73.80%
=======================================
Files 276 276
Lines 23012 23005 -7
=======================================
- Hits 16981 16978 -3
+ Misses 6031 6027 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
force-pushed
the
windows-alt-sysvol-letter
branch
from
0fb8d56 to
76b05e8
Compare
|
Also ping @JSCU-CNI since you guys also made some changes to the tar loader in the past. Unsure if this breaks anything for you. |
|
Thanks for the heads up @Schamper. I took a quick look and it seems that this change does not break anything for us. |
pyrco
approved these changes
Jan 30, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes had to be made to the tar loader, since that's a place where we unfortunately hardcoded a drive letter. Depends on fox-it/acquire#119 to make acquire also support non-default drive letters.