-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure tests and some plugins #426
Conversation
Codecov Report
@@ Coverage Diff @@
## main #426 +/- ##
==========================================
+ Coverage 74.14% 74.16% +0.02%
==========================================
Files 258 258
Lines 20632 20632
==========================================
+ Hits 15297 15302 +5
+ Misses 5335 5330 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Be aware when rebasing that MANIFEST.in also needs to be updated.
Do we need to communicate at the next release the fact that certain plugins will have a different long path name when called?
25488d0
to
500bdc4
Compare
500bdc4
to
2fb0e5a
Compare
I've rebased, everything should be up to date now. I've also updated the MANIFEST.in with the new data path.
The canonical name doesn't change, but it would be nice to mention it regardless. |
No description provided.