Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure tests and some plugins #426

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Restructure tests and some plugins #426

merged 1 commit into from
Nov 13, 2023

Conversation

Schamper
Copy link
Member

No description provided.

@Schamper Schamper self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #426 (2fb0e5a) into main (3327906) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   74.14%   74.16%   +0.02%     
==========================================
  Files         258      258              
  Lines       20632    20632              
==========================================
+ Hits        15297    15302       +5     
+ Misses       5335     5330       -5     
Flag Coverage Δ
unittests 74.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/target/plugins/apps/browser/browser.py 100.00% <ø> (ø)
dissect/target/plugins/apps/browser/chrome.py 100.00% <100.00%> (ø)
dissect/target/plugins/apps/browser/chromium.py 90.64% <100.00%> (ø)
dissect/target/plugins/apps/browser/edge.py 100.00% <100.00%> (ø)
dissect/target/plugins/apps/browser/firefox.py 88.54% <100.00%> (ø)
dissect/target/plugins/apps/browser/iexplore.py 89.87% <100.00%> (ø)
dissect/target/plugins/apps/container/docker.py 89.23% <ø> (ø)
dissect/target/plugins/apps/vpn/openvpn.py 95.52% <ø> (ø)
dissect/target/plugins/apps/vpn/wireguard.py 87.93% <ø> (ø)
dissect/target/plugins/apps/webserver/apache.py 82.27% <100.00%> (ø)
... and 4 more

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Be aware when rebasing that MANIFEST.in also needs to be updated.

Do we need to communicate at the next release the fact that certain plugins will have a different long path name when called?

@Schamper
Copy link
Member Author

I've rebased, everything should be up to date now. I've also updated the MANIFEST.in with the new data path.

Do we need to communicate at the next release the fact that certain plugins will have a different long path name when called?

The canonical name doesn't change, but it would be nice to mention it regardless.

@Schamper Schamper requested a review from pyrco November 13, 2023 11:54
@Schamper Schamper merged commit d4aaddc into main Nov 13, 2023
@Schamper Schamper deleted the restructure-tests branch November 13, 2023 12:42
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants