Fix handling of volumes at offset 0 #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 74.31% 74.35% +0.03%
==========================================
Files 258 258
Lines 20634 20640 +6
==========================================
+ Hits 15335 15346 +11
+ Misses 5299 5294 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MaxGroot
added a commit
to fox-it/citrix-netscaler-triage
that referenced
this pull request
Nov 14, 2023
Due to changes to Dissect's handling of volumes, Dissect 3.10 does not properly handle volumes at offset 0 (see also fox-it/dissect.target#443). As this is often encountered for Citrix Netscalers, this PR suggests pinning the Dissect version at 3.9 for now.
yunzheng
pushed a commit
to fox-it/citrix-netscaler-triage
that referenced
this pull request
Nov 14, 2023
Due to changes to Dissect's handling of volumes, Dissect 3.10 does not properly handle volumes at offset 0 (see also fox-it/dissect.target#443). As this is often encountered for Citrix Netscalers, this PR suggests pinning the Dissect version at 3.9 for now.
pyrco
requested changes
Nov 15, 2023
pyrco
approved these changes
Nov 16, 2023
JSCU-CNI
pushed a commit
to JSCU-CNI/dissect.target
that referenced
this pull request
Jan 2, 2024
Poeloe
pushed a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this fix I've introduced a
__type__attribute to theVolumeSystemclass. It's purpose is similar toFilesystem.__fstype__- being able to do some sort of type-check if you can't do aisinstance()check due to lazy importing.In fact, I probably want to add it to
Containertoo, and perhaps renameFilesystem.__fstype__toFilesystem.__type__- of course with the necessary deprecation warning and period.