Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify __type__ on filesystems and containers #444

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Unify __type__ on filesystems and containers #444

merged 5 commits into from
Nov 16, 2023

Conversation

Schamper
Copy link
Member

Depends on #443 for doing the same with volume systems.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a90e389) 74.35% compared to head (4a089ee) 74.37%.

Files Patch % Lines
dissect/target/plugins/os/unix/_os.py 0.00% 3 Missing ⚠️
dissect/target/plugins/os/unix/linux/esxi/_os.py 0.00% 2 Missing ⚠️
dissect/target/container.py 80.00% 1 Missing ⚠️
dissect/target/filesystem.py 92.30% 1 Missing ⚠️
...ect/target/plugins/filesystem/ntfs/mft_timeline.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   74.35%   74.37%   +0.02%     
==========================================
  Files         258      258              
  Lines       20640    20661      +21     
==========================================
+ Hits        15346    15366      +20     
- Misses       5294     5295       +1     
Flag Coverage Δ
unittests 74.37% <87.09%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from pyrco November 16, 2023 10:32
@Schamper Schamper merged commit a6796c4 into main Nov 16, 2023
@Schamper Schamper deleted the unified-type branch November 16, 2023 14:50
JSCU-CNI pushed a commit to JSCU-CNI/dissect.target that referenced this pull request Jan 2, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants