Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuse3 support #493

Merged
merged 17 commits into from
Jan 16, 2024
Merged

Add fuse3 support #493

merged 17 commits into from
Jan 16, 2024

Conversation

Miauwkeru
Copy link
Contributor

  • Initial changes
  • Researching why inodes are different
  • Remove debug code

(DIS-1967)

@Miauwkeru
Copy link
Contributor Author

Uses fox-it/fusepy3#1 for target-mount. The only thing that doesn't match up is the st_ino, but that was made fuse3 in the first place

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (0770417) 70.82% compared to head (1a527dc) 73.89%.
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/helpers/mount.py 0.00% 23 Missing ⚠️
dissect/target/tools/mount.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   70.82%   73.89%   +3.07%     
==========================================
  Files         273      273              
  Lines       22576    22663      +87     
==========================================
+ Hits        15989    16747     +758     
+ Misses       6587     5916     -671     
Flag Coverage Δ
unittests 73.89% <18.91%> (+3.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru force-pushed the DIS-1967_add-fuse3-support branch from 4556852 to f30fc1a Compare January 5, 2024 14:37
@Schamper
Copy link
Member

Schamper commented Jan 5, 2024

Also missing a new dependency in pyproject.toml or are you waiting with that until it's "out of beta"?

@Miauwkeru
Copy link
Contributor Author

Also missing a new dependency in pyproject.toml or are you waiting with that until it's "out of beta"?

Yes, we haven't published it yet. So I would not add it as a dependency yet.

@Miauwkeru Miauwkeru force-pushed the DIS-1967_add-fuse3-support branch from 0866017 to 97478ee Compare January 8, 2024 09:50
@Miauwkeru Miauwkeru requested a review from Schamper January 8, 2024 10:08
@Miauwkeru Miauwkeru requested a review from Schamper January 12, 2024 09:23
@Miauwkeru Miauwkeru requested a review from Schamper January 15, 2024 09:10
@Miauwkeru Miauwkeru force-pushed the DIS-1967_add-fuse3-support branch from 85c98ea to adb802f Compare January 15, 2024 09:10
Schamper
Schamper previously approved these changes Jan 15, 2024
@Miauwkeru Miauwkeru merged commit 18d9634 into main Jan 16, 2024
@Miauwkeru Miauwkeru deleted the DIS-1967_add-fuse3-support branch January 16, 2024 16:37
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
- Use feature flags to enable and disable it.
- When using fuse3 the st_ino now uses the dissect st_ino. (Stat information)

(DIS-1967)
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
- Use feature flags to enable and disable it.
- When using fuse3 the st_ino now uses the dissect st_ino. (Stat information)

(DIS-1967)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants