Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse3 bindings #1

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fuse3 bindings #1

merged 2 commits into from
Jan 16, 2024

Conversation

Miauwkeru
Copy link

  • Format document with ruff
  • Ignore commit for history reasons
  • Move Code around
  • Split code into seperate files
  • Make it in a pure python toml project
  • expand cfunctype definitions
  • Reorder bindings
  • Search for fuse3 instead of fuse
  • Update description and clasifiers
  • Add documentation strings for operations

@Miauwkeru
Copy link
Author

A basic change of fuse2 to fuse3 bindings. Not everything has been implemented yet. For example, the read/write_buf functions need to be implemented.

However, the ctype definitions have been updated.

@Schamper
Copy link
Member

Schamper commented Jan 3, 2024

Maybe some tests, a CI and an updated README would be nice.

@Miauwkeru
Copy link
Author

Maybe some tests, a CI and an updated README would be nice.

tests might be annoying, as it seems very annoying to test this code.. Even more as I haven't written loads of it.
I'll do some of the CI/CD for this tho.

README.rst Outdated
Comment on lines 6 to 7
The original version of `fusepy`_ was hosted on `Google Code`_, but is now
`officially hosted on GitHub`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this sentence is relevant anymore.

README.rst Outdated

- Linux (i386, x86_64, PPC, arm64, MIPS)
- Mac OS X (Intel, PowerPC)
- FreeBSD (i386, amd64)


.. _fusepy: https://github.com/fusepy/fusepy
.. _FUSE: http://fuse.sourceforge.net/
.. _MacFUSE: http://code.google.com/p/macfuse/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused links can be removed right?

@@ -28,23 +19,24 @@ See some examples of how you can use fusepy:

To get started download_ fusepy or just browse the source_.

fusepy requires FUSE 2.6 (or later) and runs on:
fusepy requires FUSE 3 (or later) and runs on:

- Linux (i386, x86_64, PPC, arm64, MIPS)
- Mac OS X (Intel, PowerPC)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is true anymore? MacFUSE doesn't support libfuse3 as far as I can see online.

Comment on lines 1 to 7
__all__ = (
"FUSE3",
"FuseOSError",
"Operations",
)

from fusepy3.fuse import FUSE3, FuseOSError, Operations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__all__ = (
"FUSE3",
"FuseOSError",
"Operations",
)
from fusepy3.fuse import FUSE3, FuseOSError, Operations
from fusepy3.fuse import FUSE3, FuseOSError, Operations
__all__ = (
"FUSE3",
"FuseOSError",
"Operations",
)

@Schamper
Copy link
Member

Schamper commented Jan 5, 2024

Will we publish this to PyPI at some point?

@Miauwkeru
Copy link
Author

Will we publish this to PyPI at some point?

I assume as much, we will probably need to change the current tags tho.

@Miauwkeru Miauwkeru requested a review from Schamper January 11, 2024 14:43
- Ports fuse2 bindings to fuse3
- Reorganizes the code
- Create a pure pyproject.toml project
- Add documentation of what to expect for certain functions
@Miauwkeru Miauwkeru dismissed Schamper’s stale review January 16, 2024 15:48

Implemented Changes

@Miauwkeru Miauwkeru merged commit c9702cc into master Jan 16, 2024
@Miauwkeru Miauwkeru deleted the fuse3-bindings branch January 16, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants