Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IIS plugin does not process logs in default dir without ApplicationHo… #549

Merged
merged 9 commits into from
Feb 27, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

…st config file (DIS-2795)

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2795_IIS_Default_logs branch 2 times, most recently from 586a2f2 to b59cb97 Compare February 20, 2024 15:56
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.02%. Comparing base (a87a5c5) to head (5cf5423).

Files Patch % Lines
dissect/target/plugins/apps/webserver/iis.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   73.98%   74.02%   +0.04%     
==========================================
  Files         285      285              
  Lines       23562    23578      +16     
==========================================
+ Hits        17432    17454      +22     
+ Misses       6130     6124       -6     
Flag Coverage Δ
unittests 74.02% <91.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cecinestpasunepipe cecinestpasunepipe merged commit a0c6c9f into main Feb 27, 2024
18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2795_IIS_Default_logs branch February 27, 2024 14:32
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants