Update openvpn configuration parsing #556
Conversation
Miauwkeru
commented
Feb 27, 2024
Miauwkeru
commented
- Process default dirs in IIS plugin (IIS plugin does not process logs in default dir without ApplicationHo… #549)
- Fix issues OpenVPN parsing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 74.02% 74.03% +0.01%
==========================================
Files 285 285
Lines 23578 23600 +22
==========================================
+ Hits 17454 17473 +19
- Misses 6124 6127 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dissect/target/helpers/configutil.py
Outdated
| @@ -228,6 +228,50 @@ def parse_file(self, fh: TextIO) -> None: | |||
| self.parsed_data = information_dict | |||
|
|
|||
|
|
|||
| class OpenVPN(Default): | |||
There was a problem hiding this comment.
This is an application specific parser, I'm not sure it belongs in this file. Is there no way to achieve something similar with this being in the openvpn.py file?
There was a problem hiding this comment.
We could just use that parser directly in that case. I will move it... as it is very specific
|
|
||
| def check_compatible(self) -> None: | ||
| if not self.configs: | ||
| raise UnsupportedPluginError("No OpenVPN configuration files found") | ||
|
|
||
| @export(record=[OpenVPNServer, OpenVPNClient]) | ||
| def config(self) -> Iterator[Union[OpenVPNServer, OpenVPNClient]]: | ||
| @arg("--export-key", action="store_true") |
There was a problem hiding this comment.
I'm divided on whether this is necessary. Maybe poll this within the (FIR) team?
| @@ -15,6 +18,7 @@ | |||
| ("string", "ca"), | |||
| ("string", "cert"), | |||
| ("string", "key"), | |||
| ("boolean", "redacted"), | |||
There was a problem hiding this comment.
| ("boolean", "redacted"), | |
| ("boolean", "key_redacted"), |
Maybe makes it a little bit clearer?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 74.02% 74.53% +0.50%
==========================================
Files 285 286 +1
Lines 23578 23673 +95
==========================================
+ Hits 17454 17644 +190
+ Misses 6124 6029 -95
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| from os.path import basename | ||
| from typing import Iterator, Union | ||
| from itertools import product | ||
| from typing import Iterable, Iterator, Union |
There was a problem hiding this comment.
| from typing import Iterable, Iterator, Union | |
| from typing import Iterable, Iterator, Optional, Union |
Added options for inline files Added specific ConfigurationParser for it Added options for both .conf and .ovpn
Co-authored-by: Erik Schamper <[email protected]>
Miauwkeru
force-pushed
the
update-openvpn-configuration
branch
from
1746a40 to
6b2d528
Compare
--------- Co-authored-by: Erik Schamper <[email protected]>
