Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock dependency in mqtt tests #574

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Mock dependency in mqtt tests #574

merged 3 commits into from
Mar 14, 2024

Conversation

Schamper
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.72%. Comparing base (5deff14) to head (9cfdf62).

❗ Current head 9cfdf62 differs from pull request most recent head 8f736aa. Consider uploading reports for the commit 8f736aa to get more accurate results

Files Patch % Lines
dissect/target/loaders/mqtt.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   74.73%   74.72%   -0.01%     
==========================================
  Files         288      288              
  Lines       23915    23891      -24     
==========================================
- Hits        17873    17853      -20     
+ Misses       6042     6038       -4     
Flag Coverage Δ
unittests 74.72% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper changed the title Make mqtt test optional if missing dependency Mock dependency in mqtt tests Mar 13, 2024
@Schamper Schamper mentioned this pull request Mar 14, 2024
@Schamper Schamper merged commit 3ab87bd into main Mar 14, 2024
16 checks passed
@Schamper Schamper deleted the optional-mqtt-test branch March 14, 2024 15:45
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants