Fix/simplify mqtt #578
Merged
Fix/simplify mqtt #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecinestpasunepipe
force-pushed
the
fix/simplify_mqtt
branch
2 times, most recently
from
9d0040b to
619c227
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
- Coverage 74.84% 74.77% -0.07%
==========================================
Files 288 287 -1
Lines 23932 23900 -32
==========================================
- Hits 17912 17872 -40
- Misses 6020 6028 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can you add a unit test that yields multiple targets? Maybe after #574 is merged in? |
cecinestpasunepipe
force-pushed
the
fix/simplify_mqtt
branch
from
619c227 to
5437b4a
Compare
Schamper
requested changes
Mar 15, 2024
Schamper
requested changes
Mar 22, 2024
Co-authored-by: Erik Schamper <[email protected]>
Schamper
approved these changes
Mar 25, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify MQTT loader to use Loader.find_all().