Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming files uploaded via the URL paste method #4005

Closed
martenson opened this issue May 2, 2017 · 11 comments
Closed

Improve naming files uploaded via the URL paste method #4005

martenson opened this issue May 2, 2017 · 11 comments

Comments

@martenson
Copy link
Member

originally implemented in #3674
reverted in #3996 because of unwanted side effects

We need a better implementation, some ideas are listed in the [comments here] (#3695 (comment))

@martenson martenson added this to the 18.05 milestone Jan 2, 2018
@chambm
Copy link
Contributor

chambm commented Jan 2, 2018

I think the easiest fix using the old implementation is to add a checkbox to the paste upload box like Rename datasets to last path segment. I agree that using the filename header from the server is even better, but that method wouldn't have worked for my situation. I was using a very simple Apache2 index to host my files, and that doesn't set the filename header. Thank goodness for Stack Overflow (er, Server Fault): https://serverfault.com/a/101966/302991

<Location /textfiles>
    SetEnvIf Request_URI "^.*/([^/]*)$" FILENAME=$1
    Header set "Content-disposition" "attachment; filename=%{FILENAME}e"
    UnsetEnv FILENAME
</Location>

So maybe a combo box instead of a checkbox, with options like:
Full URL (default)
Last path segment
Filename header

@martenson martenson modified the milestones: 18.05, 18.09 Apr 22, 2018
@martenson martenson removed this from the 18.09 milestone Sep 7, 2018
@hexylena
Copy link
Member

hexylena commented May 9, 2019

Agreed with @chambm, would love to see this re-reverted with a checkbox so users can opt-in :)

@mtekman
Copy link
Contributor

mtekman commented Oct 30, 2020

I was just thinking about this today

Screenshot_2020-10-30 Galaxy

@hexylena
Copy link
Member

hexylena commented Feb 18, 2021

Here's a video from @foellmelanie where she spends like 5-10 minutes renaming files. https://youtu.be/ad3E4VaTp7M?t=510

We really need a checkbox like @mtekman suggested. #4005 (comment), I know that galaxy-to-galaxy transfers lose information but, that doesn't affect the other many, many URLs. If you don't want to do it automatically at least have a checkbox.

I've tagged this papercut so hopefully this gets more eyes, but this is one of those missing features that regularly is an annoyance for users. #11371 is related. ping @shiltemann

the best laid plans.. #3996 (comment)

@assuntad23
Copy link
Contributor

assuntad23 commented Nov 18, 2021

@hexylena Now that pasted URLs use the datafetch tool (#11276) , is this resolved?

It looks like it's in good shape now. I uploaded three of the files from that video, and they were renamed in a way that matched what the user was doing.

https://zenodo.org/record/4544529/files/Evidence.tabular
https://zenodo.org/record/4544529/files/protein_groups.tabular
https://zenodo.org/record/4544529/files/PTXQC_report.pdf

Feel free to try those (and/or whatever URLs you'd like) and let me know if it seems this issue is resolved for you.

@hexylena
Copy link
Member

It looks like it's currently broken on main but test looks good!

image

This is so beautiful 😍 😍 😍 😍 , it's going to save so much time. @shiltemann it finally happened!!! No more mothur tutorial naming issues because people don't rename the files properly like you tell them to!

image

@shiltemann
Copy link
Member

Whoo! Thanks @assuntad23! Definitely a big QOL improvement for a lot of use cases and tutorials!

@mvdbeek
Copy link
Member

mvdbeek commented Nov 18, 2021

That was fixed in #12861, that's why it works on test and not main.
That was the renaming issue that was fixed in there, not the default name from url thing.

@hexylena
Copy link
Member

is that specific failure expected though @mvdbeek ? unsupported media type for two pasted URLs?

@mvdbeek
Copy link
Member

mvdbeek commented Nov 18, 2021

No, but that also works for me. Can you check what endpoint returned this reponse, and which browser are you using ?
Screenshot 2021-11-18 at 11 50 20
?

@hexylena
Copy link
Member

It works now, I cannot reproduce. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants