Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy uploadpost #12861

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Nov 5, 2021

Everything should work via fetch data, meaning all file data uploads use the tus protocol.
Overall this is cleaner and should make it easier (or at least not harder) to decouple upload from jQuery and sanitizing the upload modal architecture.
Also fixes #12746

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@github-actions github-actions bot added this to the 22.01 milestone Nov 5, 2021
@mvdbeek mvdbeek force-pushed the drop_legacy_uploadpost branch from c0263f2 to 05f6771 Compare November 5, 2021 17:07
@mvdbeek mvdbeek force-pushed the drop_legacy_uploadpost branch from 05f6771 to d92bf5d Compare November 5, 2021 17:22
@mvdbeek mvdbeek requested a review from guerler November 8, 2021 13:10
@guerler guerler merged commit 1f33bbe into galaxyproject:dev Nov 10, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filename is not used when uploading files by URL
4 participants