Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "End-to-End Tissue Microarray Image Analysis with Galaxy-ME" tools, workflow, and tutorial #5810

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

CameronFRWatson
Copy link
Contributor

changes

  • Updated tools, answer key history, and workflow
  • Updated tutorial text, images, references

To-do

  • Still need to create workflow tests; however, I wanted to get the PR up so that I might address any reviews and create the workflow tests in parallel

@bgruening
Copy link
Member

@CameronFRWatson the container does not work for us on EU. It seems you are using the vitessce user inside the container by default. But if you use a different user that has not the ID 1000 it will not work. How are you running this container? The last container was build differently? Can we revert to the previous owner by default?

@CameronFRWatson
Copy link
Contributor Author

Hi @bgruening. We hopefully have addressed this here: goeckslab/tools-mti#95

We just updated the existing container so there shouldn't be any need to pull any changes to test. Let us know if you continue to run into problems

@CameronFRWatson
Copy link
Contributor Author

Question as I work on resolving some of the CI errors:

Does the test data for the workflow need to be the same data used in the tutorial? I'm concerned that while the data used in the tutorial is good for learning these tools with a realistic use-case, it might be too resource and time consumptive for CI. Is it acceptable to use workflow test data that is either a subset of, or entirely different from the tutorial dataset?

@shiltemann
Copy link
Member

@CameronFRWatson no, you can use different test data if that makes more sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants