-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing struct to new functions #503
Passing struct to new functions #503
Conversation
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is almost perfect! 👏 👌 Please address the comments, sign the commits and update the description. 🙏
b884aa5
to
958b995
Compare
* Update deps * Remove unnecessary conversion * Use grpc.NewClient instead of the deprecated grpc.Dial * Remove copied loop variable * Use integer range * Remove unused nolint:wrapchecks * Fix variable usage * Use latest version of golangci-lint * Fix nil pointer error when creating a new gRPC server * Fix other minor issues
…ms into a single target (gatewayd-io#507)
* Fix issues found during code inspection * Fix issues reported by linters
c455a9a
to
0a23f48
Compare
Signed-off-by: Mostafa Moradian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🎉 I updated the description, signed the commits on your behalf and merged the latest changes from the main branch, while resolving conflicts. This PR was a blocker to many other tasks and there were only minor issues, so I fixed the issues myself, so I can merge it sooner. You really did a great job, which I am really grateful for. 🙏
Ticket(s)
Closes #208.
Description
This PR revamps the constructor functions by passing structs into them and receiving pointers (mostly) back.
Related PRs
N/A
Development Checklist
make gen-docs
command.Legal Checklist