Improve Makefile by combining all build targets for different platforms into a single target #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms into a single target
mostafa
added a commit
to likecodingloveproblems/gatewayd
that referenced
this pull request
Apr 9, 2024
…ms into a single target (gatewayd-io#507)
mostafa
added a commit
that referenced
this pull request
Apr 9, 2024
* GatewayDError initialized directly, and NewGatewayDError deleted * Pass config.Config to NewConfig function * Pass Regsitry struct to NewActRegistry function * Pass GRPCServer struct to NewGRPCServer function * Pass Registry struct to NewRegistry function * Pass Merger struct to NewMerger function * Pass Retry struct to NewRetry function * Pass Proxy struct to NewProxy function * Pass ConnWrapper struct to NewConnWrapper function * Pass Server struct to NewServer function * solving some warnings of golang-ci-lint * Update dependencies and fix issues (#505) * Update deps * Remove unnecessary conversion * Use grpc.NewClient instead of the deprecated grpc.Dial * Remove copied loop variable * Use integer range * Remove unused nolint:wrapchecks * Fix variable usage * Use latest version of golangci-lint * Fix nil pointer error when creating a new gRPC server * Fix other minor issues * Improve Makefile by combining all build targets for different platforms into a single target (#507) * Fix issues found during code inspection (#508) * Fix issues found during code inspection * Fix issues reported by linters * Address comments --------- Signed-off-by: Mostafa Moradian <[email protected]> Co-authored-by: mam <[email protected]> Co-authored-by: Mostafa Moradian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s)
N/A
Description
This PR will improve the Makefile by combining all the build targets for different platforms into a single target. This target,
build-platform, can be copied for other plugins as well.Related PRs
N/A
Development Checklist
Legal Checklist