Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {Convert,TryConvert} traits for coordinate value type conversion. #836

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jun 2, 2022

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

  • Add table of contents entry

Fixes https//github.com//issues/617

@frewsxcv frewsxcv changed the title Add {Convert,TryConvert} traits for coordinate value type conversion. Add {Convert,TryConvert} traits for coordinate value type conversion. Jun 2, 2022
@frewsxcv frewsxcv force-pushed the frewsxcv-convert branch from cde7961 to d585fd3 Compare June 2, 2022 16:48
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the changelog entry

@michaelkirk michaelkirk mentioned this pull request Jun 2, 2022
2 tasks
@frewsxcv
Copy link
Member Author

frewsxcv commented Jun 2, 2022

bors r=michaelkirk

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

Build succeeded:

@bors bors bot merged commit 272d5b3 into main Jun 2, 2022
@bors bors bot deleted the frewsxcv-convert branch June 2, 2022 22:09
bors bot added a commit that referenced this pull request Jun 3, 2022
837: Map coords takes a coordinate r=frewsxcv a=michaelkirk

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md).
- [x] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

FIXES #804 

Note there will be a little conflict with #836 - whoever merges second will have to make a small update.

Co-authored-by: Michael Kirk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants