Map coords takes a coordinate #837
Merged
+243
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
commented
Jun 2, 2022
| #[deprecated( | ||
| since = "0.21.0", | ||
| note = "use `MapCoords::try_map_coords` which takes a `Coordinate` instead of an (x,y) tuple" | ||
| )] | ||
| pub trait TryMapCoords<T, NT, E> { |
There was a problem hiding this comment.
Note, for the deprecated methods, I left the signatures as (T, T) tuples, figuring they'll go away soon enough and this way we can better have the compiler tell the users what to do.
frewsxcv
approved these changes
Jun 2, 2022
geo/src/algorithm/map_coords.rs
Outdated
| /// use approx::assert_relative_eq; | ||
| /// | ||
| /// let p1 = Point::new(10., 20.); | ||
| /// let p2 = p1.map_coords(|(x, y)| (x + 1000., y * 2.)); | ||
| /// let p2 = p1.map_coords(|Coordinate { x, y }| Coordinate { x: x + 1000., y: y * 2. }); | ||
| /// | ||
| /// assert_relative_eq!(p2, Point::new(1010., 40.), epsilon = 1e-6); | ||
| /// ``` | ||
| /// | ||
| /// You can convert the coordinate type this way as well |
There was a problem hiding this comment.
Unrelated, but we should probs advertise Convert here now?
There was a problem hiding this comment.
I've rebased, and pushed up a new commit which references Convert for the case of simply changing numeric type , and then updated this example to solve a more complex problem involving both type conversion and a transformation for which Convert would be insufficient.
michaelkirk
force-pushed
the
mkirk/map-coords
branch
from
96564f7 to
ea6b1cb
Compare
michaelkirk
force-pushed
the
mkirk/map-coords
branch
from
ea6b1cb to
5238e31
Compare
|
bors r=frewsxcv |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.FIXES #804
Note there will be a little conflict with #836 - whoever merges second will have to make a small update.