track and return more of: formVersion, deviceId, userAgent #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* now to do it for odata too.
* the deviceId returned on the logical api will always be the deviceId associated with the initial submission. * the userAgent is only remembered and returned per version.
issa-tseng
force-pushed
the
issa/more-submission-meta
branch
from
0baae9e to
df77456
Compare
issa-tseng
commented
Dec 16, 2021
| @@ -215,6 +215,7 @@ describe('managed encryption', () => { | |||
| .then((keyId) => new Promise((done) => | |||
| zipStreamToFiles(asAlice.get(`/v1/projects/1/forms/simple/submissions.csv.zip?${keyId}=supersecret`), (result) => { | |||
| result.filenames.should.eql([ 'simple.csv' ]); | |||
| console.log(result['simple.csv']); | |||
ktuite
approved these changes
Dec 16, 2021
This was referenced Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the goal here is to do the following:
FormVersion/formVersionfield on csv/odata export. this field reflects only the original "root" version of a submission, it does not update if the submission is edited.formVersionfield on extended submission version request. ditto it's the root version.userAgentfor each submission version.deviceIdfor each submission version.this pr does not deprecate the existing
deviceIdon the logical submission, which will also always reflect the initial submission. it only adds an additionaldeviceIdto version requests.this pr does not add
userAgentto submission logical requests. maybe it should.