Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining mixins with composables #676

Closed
matthew-white opened this issue Dec 5, 2022 · 0 comments
Closed

Replace remaining mixins with composables #676

matthew-white opened this issue Dec 5, 2022 · 0 comments
Assignees
Labels
refactor Improves code without altering behavior

Comments

@matthew-white
Copy link
Member

Vue 3 strongly encourages the use of composables over mixins. Composables can be used in any component, but mixins can only be used within components that use the Options API, not the new Composition API. I've been writing more components using the Composition API, which can be very convenient. However, right now many new components can't be written using the Composition API, simply because they use a mixin that we haven't yet converted to a composable. I've converted a few mixins to composables already, but there are still a few key mixins left to convert. I started working on that during v2022.3, and I'm close to being done, but I haven't finished yet. In particular, I'm not sure whether I should complete #675 before or after converting the request mixin to a composable. But even if we don't convert the request mixin to a composable immediately, I think it'd be good to finish converting the other mixins during v2023.1 in order to continue making progress on this issue.

@matthew-white matthew-white added the refactor Improves code without altering behavior label Dec 5, 2022
@matthew-white matthew-white added this to the v2023.1 milestone Dec 5, 2022
@matthew-white matthew-white self-assigned this Dec 5, 2022
@matthew-white matthew-white moved this to 🕒 backlog in ODK Central Dec 20, 2022
@matthew-white matthew-white removed this from the v2023.1 milestone Jan 24, 2023
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Feb 11, 2023
matthew-white added a commit that referenced this issue Feb 11, 2023
@matthew-white matthew-white moved this from ✏️ in progress to 🕒 backlog in ODK Central Oct 2, 2023
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central Feb 23, 2024
@matthew-white matthew-white moved this from ✏️ in progress to 🕒 backlog in ODK Central Mar 26, 2024
@matthew-white matthew-white moved this from 🕒 backlog to ✏️ in progress in ODK Central May 7, 2024
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves code without altering behavior
Projects
Status: ✅ done
Development

No branches or pull requests

1 participant