Add ability to cache composable results #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
commented
Feb 10, 2023
Comment on lines
-27
to
+33
| export default () => { | ||
| const { i18n } = inject('container'); | ||
| return { | ||
| // Returns a message describing an audit action. | ||
| actionMessage: (action) => { | ||
| const path = actionPath(action); | ||
| return i18n.te(path, i18n.fallbackLocale) ? i18n.t(path) : null; | ||
| } | ||
| }; | ||
| }; | ||
| export default memoizeForContainer(({ i18n }) => ({ | ||
| // Returns a message describing an audit action. | ||
| actionMessage: (action) => { | ||
| const path = actionPath(action); | ||
| return i18n.te(path, i18n.fallbackLocale) ? i18n.t(path) : null; | ||
| } | ||
| })); |
There was a problem hiding this comment.
Today, each AuditRow component that uses the useAudit() composable ends up creating its own actionMessage() function. After this change, the same function will be returned to each component.
This was referenced Feb 12, 2023
Open
ktuite
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a precursor to #676.