-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add liveness check for workers #140
Conversation
@grugnog can you please check this PR ? This issue has been reported by many. |
@shubhwip we will need to add the new values to the README but otherwise this looks good to me. We don't want to break installs though, so I don't think we should merge until upstream is merged however, and we can't release until upstream is released. |
bbc73d9
to
7817bfd
Compare
Update README file closes getredash#72
@grugnog made the changes as requested and now upstream is merged. |
Would love to see this merged; currently facing issues with workers silently dying and we can only manually bounce them. |
@grugnog when do you plan to merge the changes as upstream changes are merged months ago :) ? |
@grugnog please kindly take a look |
Now that Redash is a Community led project, we've been madly working through the outstanding PRs, Dependabot issues, (etc) getting things cleaned up and ready for a next release. It's going to be a few weeks away though. We might be able to get something like an "Redash 11.0.0 alpha 1" (or beta) out the door in a fortnight or so, but we'll see. 😄 |
@grugnog If you want to create some kind of preview release for people to do with in the meantime, then please feel encouraged to do so. It could be considered a good initial shake out to see if we've busted anything non-obvious in the mad rush of merging PRs and similar. 😄 |
That sounds good - I am working on getting the other PRs tested and merged, then will look at this |
@AndrewChubatiuk Does this PR seem sensible to you? |
closes #72
Dependent on PR getredash/redash#5886 and it is merged already.
Related Issues :
getredash/redash#5885
#124
#72
getredash/redash#5801
More context
liveness check is based on
rq info command returns monitoring status of redash workers and other status checks
Sample Output