Add liveness check for workers #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shubhwip Can you trigger the CI to test if there still are failings? |
shubhwip
force-pushed
the
feature/worker_healthcheck_5885
branch
from
e0c50ea to
a10b1ce
Compare
|
@lucasfcnunes Can I draw your attention on this as this issue is faced by many people and myself everyday ? |
shubhwip
force-pushed
the
feature/worker_healthcheck_5885
branch
from
a10b1ce to
7d8dec9
Compare
arikfr
reviewed
Mar 24, 2023
shubhwip
force-pushed
the
feature/worker_healthcheck_5885
branch
from
9be0f6e to
baf196d
Compare
arikfr
approved these changes
Mar 27, 2023
|
Thanks, @shubhwip ! Note that I renamed the health check name. |
AkaashK
pushed a commit
to tharzeez/redash
that referenced
this pull request
Jul 18, 2023
* Add liveness check script for workers closes getredash#5885 * delete extra script * Rename worker_healthcheck -> workers_healthcheck --------- Co-authored-by: Arik Fraimovich <[email protected]>
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* Add liveness check script for workers closes getredash#5885 * delete extra script * Rename worker_healthcheck -> workers_healthcheck --------- Co-authored-by: Arik Fraimovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5885
liveness check is based on
rq info command returns monitoring status of redash workers and other status checks
Sample Output
What type of PR is this?
Description
How is this tested?
I have run rq info command in k8s pods and based on that test i have written a healthcheck.
Related Tickets & Documents
Similar Reported Issues Reference :
getredash/contrib-helm-chart#124
getredash/contrib-helm-chart#72
#5801
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Additional Comments
After this is merged, next change is in helm charts repo
getredash/contrib-helm-chart#140