Configure Review layout for SDC catalog application #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we directly launch the review mode by providing both the questionnaire JSON and the questionnaire response? This way, when the layout is displayed in review mode, it will show the pre-filled answers. If the user wants to edit those answers, they can click on the edit button at the top.
nsabale7
reviewed
Feb 4, 2025
catalog/src/main/java/com/google/android/fhir/catalog/DemoQuestionnaireFragment.kt
Show resolved
Hide resolved
jingtang10
requested changes
Mar 12, 2025
Comment on lines
+2
to
+8
| "status": "draft", | ||
| "publisher": "Roshnee team", | ||
| "name": "covid-19-screening", | ||
| "title": "COVID-19 Screening", | ||
| "resourceType": "Questionnaire", | ||
| "subjectType": [ | ||
| "Encounter" |
There was a problem hiding this comment.
can you remove these fields? would be good for the questionnaire to be minimal
| ), | ||
| REVIEW(R.drawable.ic_reviewlayout, R.string.layout_name_review, ""), | ||
| READ_ONLY(R.drawable.ic_readonlylayout, R.string.layout_name_read_only, ""), | ||
| REVIEW(R.drawable.ic_reviewlayout, R.string.layout_name_review, "layout_review.json", true), |
There was a problem hiding this comment.
@santosh-pingle fyi
I was asking santosh to see if there's a way to use lambda to configure this.. it's sort of annoying to keep adding new arguments to this. @rahulmalhotra can you think of a way to do this?
santosh has a similar pr as well #2803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2777
Description
This change configures Review layout for SDC Catalog Application. It consist of the following updates:
enableReviewModeto Layout enum underLayoutListViewModel.ktand pass it astruefor the REVIEW enum value along withlayout_review.jsonto render questionnaireDemoQuestionnaireFragment.ktand use it to show Review Page when its value istruelayout_review.jsonto render questionnaire properlyAlternative(s) considered
N/A
Type
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.